GitHub Issue 954: Add error for duplicate values for parent inputs#7559
Merged
GitHub Issue 954: Add error for duplicate values for parent inputs#7559
Conversation
labkey-susanh
approved these changes
Apr 8, 2026
| { | ||
| List<String> valueList = values.toList(); | ||
| Set<String> valueSet = new HashSet<>(); | ||
| List<String> duplicates = valueList.stream().filter(s -> !valueSet.add(s)).toList(); |
Contributor
There was a problem hiding this comment.
The conversion from the stream to the list to the stream and then again to the stream is, uh, unfortunate and kind of defeats one of the purposes of using the stream. I would hope that we don't have a lot of values, of course, so maybe not a big deal (and I don't have a better suggestion).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
GitHub Issue 954: Add error for duplicate values for parent inputs
Related Pull Requests
Changes